Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same deploy.sh when deploy katib components #284

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

ytetra
Copy link
Contributor

@ytetra ytetra commented Dec 11, 2018

We need to fix two deploy.sh when components updated, so I fixed deploy.sh in MinikubeDemo to use scripts/deploy.sh for maintainability.


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @ytetra. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YujiOshima
Copy link
Contributor

/ok-to-test

@hougangliu
Copy link
Member

@ytetra you can rebase your PR to pass kubeflow-katib-presubmit (the fix had been merged into master branch)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@ytetra
Copy link
Contributor Author

ytetra commented Dec 14, 2018

I missed rebase. Please wait for a while.

@googlebot
Copy link

CLAs look good, thanks!

@ytetra
Copy link
Contributor Author

ytetra commented Dec 14, 2018

/retest

@YujiOshima
Copy link
Contributor

/lgtm

@YujiOshima
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4be865e into kubeflow:master Dec 16, 2018
@ytetra ytetra deleted the deploy branch December 21, 2018 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants